Fix get_used_percentage for non-LSO deployments in test_mon_data_avail_warn#15138
Open
amr1ta wants to merge 1 commit into
Open
Fix get_used_percentage for non-LSO deployments in test_mon_data_avail_warn#15138amr1ta wants to merge 1 commit into
amr1ta wants to merge 1 commit into
Conversation
…l_warn PR red-hat-storage#14707 split get_used_percentage() into LSO/non-LSO branches and applied .strip().splitlines()[-1] to the LSO path to extract the data line from df -Th output. The non-LSO else branch was missing this step, causing mount_details.split()[5] to hit 'Use%' from the df header row instead of the actual percentage, raising ValueError: invalid literal for int() with base 10: 'Use'. Apply the same .strip().splitlines()[-1] to the non-LSO branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amr1ta The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #14707 split get_used_percentage() into LSO/non-LSO branches and applied .strip().splitlines()[-1] to the LSO path to extract the data line from df -Th output. The non-LSO else branch was missing this step, causing mount_details.split()[5] to hit 'Use%' from the df header row instead of the actual percentage, raising ValueError: invalid literal for int() with base 10: 'Use'.
Apply the same .strip().splitlines()[-1] to the non-LSO branch.